Improve union case serialization & added tests#29
Open
realvictorprm wants to merge 2 commits intofsprojects:masterfrom
Open
Improve union case serialization & added tests#29realvictorprm wants to merge 2 commits intofsprojects:masterfrom
realvictorprm wants to merge 2 commits intofsprojects:masterfrom
Conversation
Author
|
The major change in here is that union cases are now serialized as objects with fields. |
Collaborator
|
I will consider this change. Though it's a breaking change (and not a breaking bugfix) to current logic. So such change in logic should be either under config flag or introduced in major release. |
Author
|
I did this minimal change during company time. I'm not using it anymore there but I'm willing to polish it in my private time, however this will take some time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I prefer this way of serialization of union cases. It's well usable from other languages like C#.