Skip to content

Fix TypeProviderInstantiation.fs to include StrictBooleans parameter for CsvProvider#1622

Closed
Copilot wants to merge 1 commit intorepo-assist/feature-strict-booleans-1417-80161456360f4ff8from
copilot/sub-pr-1621
Closed

Fix TypeProviderInstantiation.fs to include StrictBooleans parameter for CsvProvider#1622
Copilot wants to merge 1 commit intorepo-assist/feature-strict-booleans-1417-80161456360f4ff8from
copilot/sub-pr-1621

Conversation

Copy link
Contributor

Copilot AI commented Feb 22, 2026

TypeProviderInstantiation.fs was missing the StrictBooleans static parameter added to CsvProvider in #1621, causing a mismatch between the test infrastructure and the actual provider argument list.

Changes to tests/FSharp.Data.DesignTime.Tests/TypeProviderInstantiation.fs

  • CsvProviderArgs record — added StrictBooleans : bool field after PreferDateOnly
  • GenerateType — added box x.StrictBooleans at position 17, matching args.[17] in CsvProvider.fs
  • Parse — added StrictBooleans = false default, consistent with how PreferDateOnly is handled

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copy link
Contributor Author

Copilot AI commented Feb 22, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • api.worldbank.org
    • Triggering command: /usr/share/dotnet/dotnet /usr/share/dotnet/dotnet /usr/share/dotnet/sdk/8.0.123/FSharp/fsc.dll @/tmp/MSBuildTempboiHgl/tmpf8d572ce02c3492c913534842a024bb1.rsp (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] WIP address feedback on TypeProviderInstantiation.fs Fix TypeProviderInstantiation.fs to include StrictBooleans parameter for CsvProvider Feb 22, 2026
@dsyme dsyme marked this pull request as ready for review February 22, 2026 22:08
@dsyme dsyme closed this Feb 22, 2026
@dsyme dsyme reopened this Feb 22, 2026
@dsyme dsyme closed this Feb 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants