Fix singularization of words ending in ases#1524
Open
bisen2 wants to merge 3 commits intofsprojects:mainfrom
Open
Fix singularization of words ending in ases#1524bisen2 wants to merge 3 commits intofsprojects:mainfrom
ases#1524bisen2 wants to merge 3 commits intofsprojects:mainfrom
Conversation
Contributor
|
@bisen2 I'm OK with this change. Could you add a major version bump as part of the change? Thanks |
Contributor
Author
|
Sure thing. Do you want me to mark it as a beta or just go straight for the 7.0.1, @dsyme? |
Contributor
|
@bisen2 Just straight to 7.0.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR would resolve #1508.
It would, however, be a breaking change. Any consumers currently using any
*aseswords as singular*asiswould need to update their type names after updating this package.I'm not sure if this is actually a change we would want to merge given the breaking nature, but figured I would open the PR and see what the maintainers thought.