Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plotting styles #98

Merged
merged 38 commits into from
Oct 13, 2022
Merged

Plotting styles #98

merged 38 commits into from
Oct 13, 2022

Conversation

fsoubelet
Copy link
Owner

@fsoubelet fsoubelet commented Oct 12, 2022

  • Add pyhdtoolkit.plotting.styles with submodules (still needs paper styles to be created) and functionality to install them
  • Add a pyhdtoolkit.utils.logging module with the condif_logger function.
  • Remove pyhdtoolkit.utils.defaults.
  • Adapt documentation and galleries.
  • Removed PLOT_PARAMS altogether, simpler more adapted styles were created.
  • Removed a few stragglers of hardcoded lw= in plotters.

Already published as 1.0.0rc2 then 1.0.0rc3, will move version to 1.0.0 before merging.

@fsoubelet fsoubelet added Documentation Improvements or additions to documentation Enhancement Improvements to an existing feature Bugfix Feature Request Addition of a feature labels Oct 12, 2022
@fsoubelet fsoubelet added this to the 1.0.0 milestone Oct 12, 2022
@fsoubelet fsoubelet self-assigned this Oct 12, 2022
@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Base: 98.50% // Head: 98.50% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (d34fded) compared to base (8fc39f7).
Patch coverage: 98.50% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #98   +/-   ##
=======================================
  Coverage   98.50%   98.50%           
=======================================
  Files          47       50    +3     
  Lines        2268     2281   +13     
=======================================
+ Hits         2234     2247   +13     
  Misses         34       34           
Impacted Files Coverage Δ
pyhdtoolkit/maths/stats_fitting.py 88.88% <0.00%> (ø)
pyhdtoolkit/plotting/utils.py 100.00% <ø> (ø)
pyhdtoolkit/cpymadtools/lhc.py 100.00% <100.00%> (ø)
pyhdtoolkit/cpymadtools/tune.py 90.62% <100.00%> (ø)
pyhdtoolkit/optics/beam.py 100.00% <100.00%> (ø)
pyhdtoolkit/plotting/aperture.py 100.00% <100.00%> (ø)
pyhdtoolkit/plotting/envelope.py 100.00% <100.00%> (ø)
pyhdtoolkit/plotting/lattice.py 100.00% <100.00%> (ø)
pyhdtoolkit/plotting/sbs/coupling.py 100.00% <100.00%> (ø)
pyhdtoolkit/plotting/sbs/phase.py 100.00% <100.00%> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fsoubelet fsoubelet merged commit 1fca6d7 into master Oct 13, 2022
@fsoubelet fsoubelet deleted the plotting_styles branch October 13, 2022 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix Documentation Improvements or additions to documentation Enhancement Improvements to an existing feature Feature Request Addition of a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant