Skip to content

Conversation

@norberttech
Copy link
Contributor

The goal of this pull request is to cover current functionalities with behat scenarios, this will give us more guaranty in the future that new things didnt break anything.
This PR must be finished before adding dashboards feature.

I know this is not the proper order but I hope to that every PR after this one will be created in BDD methodology

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where's Then? Same questions to several scenarios below :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right, its because in previous version of this feature "Services configuration" scenario was a "Background" :P Thanks for pointing this out! Now I'm not sure if it was a good move to change it into scenario. I must rethink this decision again. I would be really glad to hear any suggestions about this part of features.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the outcome of configuring all this things? If there's none, there's no need of having them here :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually there is one, the main menu structure is result of this configuration. I think its worth to tell how this menu was builded.
Maybe...

Feature: Admin panel main page
  In order to generate admin panel for Symfony2 project
  As a developer
  I need to install FSiAdminBundle and configure few admin elements

  Scenario: Admin panelu menu configuration
    Given the following services were registered
      | Id                                  | Class                                | Tag           | Tag alias |
      | fixtures_bundle.admin.news          | FSi\FixturesBundle\Admin\News        | admin.element |           |
      | fixtures_bundle.admin.home_page     | FSi\FixturesBundle\Admin\HomePage    | admin.element | structure |
      | fixtures_bundle.admin.about_us_page | FSi\FixturesBundle\Admin\AboutUsPage | admin.element | structure |
    And translations are enabled in application
    When I open "Admin panel" page
    Then I should see main menu with following elements 
      | Element name  | Element group  |
      | News          |                |
      | Home page     | Site structure |
      | About us page | Site structure |

What do you think about it?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If something is not relevant to the current scenario, but it is required for the app to work, I'd hide it.

New scenario looks much better.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! 🍻

@norberttech
Copy link
Contributor Author

@chives review this please. I think its ready to merge

norberttech added a commit that referenced this pull request Dec 2, 2013
@norberttech norberttech merged commit 0ca2f06 into fsi-open:master Dec 2, 2013
@norberttech norberttech deleted the behat branch December 2, 2013 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants