Don't call stream.setEncoding() if options.encoding is strictly null #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When stream.setEncoding is called, it additionally sets the decoder in the underlying stream. Unfortunately, despite what the official documentation says, calling
setEncoding(null)
sets the underlying decoder to UTF-8.This causes problems when you need the raw buffer data of a file to pipe elsewhere, such as a zlib.gunzip stream for gunzipping files.
This pull request allows specifying
{ encoding: null }
to disable that call.