RFC-1090 for unmanaged generic struct types#480
Merged
cartermp merged 17 commits intofsharp:masterfrom Jul 27, 2020
Merged
Conversation
6 tasks
vzarytovskii
changed the title
cartermp
requested changes
Jun 28, 2020
Member
cartermp
left a comment
cartermp
left a comment
There was a problem hiding this comment.
This is good, but does require some additional consideration. We'll likely want to do a design review here since there may be some tricky pieces. But I wouldn't consider that a blocker on continuing the work on the feature itself.
RFCs/FS-1090-Generic-struct-type-whose-fields-are-all-unmanaged-types-is-unmanaged.md
Outdated
Show resolved
Hide resolved
RFCs/FS-1090-Generic-struct-type-whose-fields-are-all-unmanaged-types-is-unmanaged.md
Show resolved
Hide resolved
RFCs/FS-1090-Generic-struct-type-whose-fields-are-all-unmanaged-types-is-unmanaged.md
Outdated
Show resolved
Hide resolved
RFCs/FS-1090-Generic-struct-type-whose-fields-are-all-unmanaged-types-is-unmanaged.md
Show resolved
Hide resolved
RFCs/FS-1090-Generic-struct-type-whose-fields-are-all-unmanaged-types-is-unmanaged.md
Show resolved
Hide resolved
RFCs/FS-1090-Generic-struct-type-whose-fields-are-all-unmanaged-types-is-unmanaged.md
Outdated
Show resolved
Hide resolved
…supportedd types section; Updated motivation section
cartermp
requested changes
Jun 30, 2020
Member
cartermp
left a comment
cartermp
left a comment
There was a problem hiding this comment.
Needs some more work, but this is getting closer. I think it would be especially helpful to have more examples of working/not-working in each case, since these can also be lifted straight into test cases for the PR.
RFCs/FS-1090-Generic-struct-type-whose-fields-are-all-unmanaged-types-is-unmanaged.md
Outdated
Show resolved
Hide resolved
RFCs/FS-1090-Generic-struct-type-whose-fields-are-all-unmanaged-types-is-unmanaged.md
Outdated
Show resolved
Hide resolved
RFCs/FS-1090-Generic-struct-type-whose-fields-are-all-unmanaged-types-is-unmanaged.md
Show resolved
Hide resolved
RFCs/FS-1090-Generic-struct-type-whose-fields-are-all-unmanaged-types-is-unmanaged.md
Outdated
Show resolved
Hide resolved
RFCs/FS-1090-Generic-struct-type-whose-fields-are-all-unmanaged-types-is-unmanaged.md
Outdated
Show resolved
Hide resolved
RFCs/FS-1090-Generic-struct-type-whose-fields-are-all-unmanaged-types-is-unmanaged.md
Show resolved
Hide resolved
RFCs/FS-1090-Generic-struct-type-whose-fields-are-all-unmanaged-types-is-unmanaged.md
Show resolved
Hide resolved
RFCs/FS-1090-Generic-struct-type-whose-fields-are-all-unmanaged-types-is-unmanaged.md
Show resolved
Hide resolved
RFCs/FS-1090-Generic-struct-type-whose-fields-are-all-unmanaged-types-is-unmanaged.md
Show resolved
Hide resolved
RFCs/FS-1090-Generic-struct-type-whose-fields-are-all-unmanaged-types-is-unmanaged.md
Outdated
Show resolved
Hide resolved
…d-types-is-unmanaged.md Co-authored-by: Phillip Carter <pcarter@fastmail.com>
…d-types-is-unmanaged.md Co-authored-by: Phillip Carter <pcarter@fastmail.com>
…d-types-is-unmanaged.md Co-authored-by: Phillip Carter <pcarter@fastmail.com>
…d-types-is-unmanaged.md Co-authored-by: Phillip Carter <pcarter@fastmail.com>
…d-types-is-unmanaged.md Co-authored-by: Phillip Carter <pcarter@fastmail.com>
…d-types-is-unmanaged.md Co-authored-by: Phillip Carter <pcarter@fastmail.com>
…d-types-is-unmanaged.md Co-authored-by: Phillip Carter <pcarter@fastmail.com>
…Re-phrased some definitions
cartermp
requested changes
Jul 2, 2020
RFCs/FS-1090-Generic-struct-type-whose-fields-are-all-unmanaged-types-is-unmanaged.md
Outdated
Show resolved
Hide resolved
RFCs/FS-1090-Generic-struct-type-whose-fields-are-all-unmanaged-types-is-unmanaged.md
Outdated
Show resolved
Hide resolved
RFCs/FS-1090-Generic-struct-type-whose-fields-are-all-unmanaged-types-is-unmanaged.md
Outdated
Show resolved
Hide resolved
RFCs/FS-1090-Generic-struct-type-whose-fields-are-all-unmanaged-types-is-unmanaged.md
Outdated
Show resolved
Hide resolved
RFCs/FS-1090-Generic-struct-type-whose-fields-are-all-unmanaged-types-is-unmanaged.md
Outdated
Show resolved
Hide resolved
RFCs/FS-1090-Generic-struct-type-whose-fields-are-all-unmanaged-types-is-unmanaged.md
Outdated
Show resolved
Hide resolved
TIHan
approved these changes
Jul 10, 2020
Contributor
TIHan
left a comment
TIHan
left a comment
There was a problem hiding this comment.
So far this looks good. I'm glad modreq was mentioned as well as the unmanaged attribute.
…d-types-is-unmanaged.md Co-authored-by: Phillip Carter <pcarter@fastmail.com>
…d-types-is-unmanaged.md Co-authored-by: Phillip Carter <pcarter@fastmail.com>
…d-types-is-unmanaged.md Co-authored-by: Phillip Carter <pcarter@fastmail.com>
…d-types-is-unmanaged.md Co-authored-by: Phillip Carter <pcarter@fastmail.com>
vzarytovskii
changed the title
vzarytovskii
changed the title
Contributor
|
LGTM |
cartermp
approved these changes
Jul 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An RFC for generic struct type whose fields are all unmanaged types is unmanaged suggestion.