Skip to content

Integrate sourcelink #950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 30 commits into from
Jun 20, 2020
Merged

Integrate sourcelink #950

Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
eb0fb19
Added readme file with testing proposal
vzarytovskii Jun 8, 2020
d38b1a3
[WIP] Moving to xUnit
vzarytovskii Jun 9, 2020
d0306f0
[WIP] Migrate Compiler.UnitTests to xUnit
vzarytovskii Jun 9, 2020
f8b3b4e
Use FluentAssertions in unit tests
vzarytovskii Jun 9, 2020
b0bd54d
Added new xUnit test project Compiler.UnitTests
vzarytovskii Jun 9, 2020
49347bc
Fixed CompilerAssert for non-windows; Updated README
vzarytovskii Jun 10, 2020
9f819b5
Fix paths when search for nuget packages
vzarytovskii Jun 15, 2020
68514a6
Confirms that dobang is not, in fact, simple (#9413)
baronfel Jun 10, 2020
2e766b5
Fix missing versions in FSharp.Compiler.Service interactive logo. (#9…
nightroman Jun 10, 2020
6856d2c
perform sourceExpr translation on match-bang expressions (#9407)
baronfel Jun 11, 2020
f375e08
Replace throw with EDI throw in CE catch handlers, fixes #8529 (#8882)
NinoFloris Jun 11, 2020
a62b74c
Fix recovery #9420 (#9426)
KevinRansom Jun 11, 2020
996bb82
Fixed paths if NUGET_PACKAGES is defined (do not apppend '.nuget/pack…
vzarytovskii Jun 15, 2020
37b2be1
Fixed platform name 'windows'->'win'
vzarytovskii Jun 15, 2020
3f9b5aa
Fixed path to FSI for scripts tests
vzarytovskii Jun 15, 2020
34ff477
Revert acccidental typo
vzarytovskii Jun 15, 2020
975e10c
migrate to netcoreapp3.1 (#9448)
brettfo Jun 15, 2020
fae0dff
Use netcoreapp3.1 in tests as well
vzarytovskii Jun 16, 2020
204fd35
Revert "Use netcoreapp3.1 in tests as well"
vzarytovskii Jun 16, 2020
7b29b0f
Fix 9449 (#9456)
dsyme Jun 16, 2020
e3e5617
Small improvement for String.length (#9469)
abelbraaksma Jun 17, 2020
c6a5f50
Move `String.length` to the top of its module so that the `length` fu…
abelbraaksma Jun 18, 2020
25db4ec
enable sourcelink packaging for FCS, and embed PDBs
baronfel Jun 18, 2020
5fd183f
nameof fixes (#9498)
dsyme Jun 18, 2020
217f7f2
reset vs tool version (#9500)
brettfo Jun 18, 2020
8b0e119
update workflows to always upload test results/not fail when one fail…
baronfel Jun 20, 2020
87f7353
update baseline for semver diff
baronfel Jun 20, 2020
184d6c5
release notes
baronfel Jun 20, 2020
31b30b3
handle known test failures
baronfel Jun 20, 2020
19d9e06
split ci steps and handle failures in a different way
baronfel Jun 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed paths if NUGET_PACKAGES is defined (do not apppend '.nuget/pack… 
…ages' to it for 2nd time).
  • Loading branch information
@vzarytovskii @baronfel
vzarytovskii authored and baronfel committed Jun 20, 2020
commit 996bb829c4ed14cbcedd908b779d47c4efe4f3b6
14 changes: 7 additions & 7 deletions tests/FSharp.Test.Utilities/TestFramework.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,13 +172,13 @@ type FSLibPaths =
{ FSCOREDLLPATH : string }

let getPackagesDir () =
let p = match Environment.GetEnvironmentVariable("NUGET_PACKAGES") with
| null ->
match Environment.GetEnvironmentVariable("USERPROFILE") with
| null -> Environment.GetEnvironmentVariable("HOME")
| p -> p
| path -> path
p ++ ".nuget" ++ "packages"
match Environment.GetEnvironmentVariable("NUGET_PACKAGES") with
| null ->
let path = match Environment.GetEnvironmentVariable("USERPROFILE") with
| null -> Environment.GetEnvironmentVariable("HOME")
| p -> p
path ++ ".nuget" ++ "packages"
| path -> path

let requireFile dir path =
// Linux filesystems are (in most cases) case-sensitive.
Expand Down