Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add clone trait to GetOptions struct #2

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

add clone trait to GetOptions struct #2

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e34c98c
add clone trait to GetOptions struct
fsdvh Aug 13, 2024
e1a48d9
fixes
fsdvh Aug 13, 2024
63885a3
docs
fsdvh Aug 13, 2024
32f0221
revert some changes
fsdvh Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions object_store/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,14 +38,11 @@
//!
//! # Highlights
//!
//! 1. A high-performance async API focused on providing a consistent interface
//! mirroring that of object stores such as [S3]
//! 1. A high-performance async API focused on providing a consistent interface mirroring that of object stores such as [S3]
//!
//! 2. Production quality, leading this crate to be used in large
//! scale production systems, such as [crates.io] and [InfluxDB IOx]
//! 2. Production quality, leading this crate to be used in large scale production systems, such as [crates.io] and [InfluxDB IOx]
//!
//! 3. Support for advanced functionality, including atomic, conditional reads
//! and writes, vectored IO, bulk deletion, and more...
//! 3. Support for advanced functionality, including atomic, conditional reads and writes, vectored IO, bulk deletion, and more...
//!
//! 4. Stable and predictable governance via the [Apache Arrow] project
//!
Expand Down Expand Up @@ -97,8 +94,7 @@
//! * All operations are atomic, and readers cannot observe partial and/or failed writes
//! * Methods map directly to object store APIs, providing both efficiency and predictability
//! * Abstracts away filesystem and operating system specific quirks, ensuring portability
//! * Allows for functionality not native to filesystems, such as operation preconditions
//! and atomic multipart uploads
//! * Allows for functionality not native to filesystems, such as operation preconditions and atomic multipart uploads
//!
//! This crate does provide [`BufReader`] and [`BufWriter`] adapters
//! which provide a more filesystem-like API for working with the
Expand Down Expand Up @@ -911,7 +907,7 @@ pub struct ObjectMeta {
}

/// Options for a get request, such as range
#[derive(Debug, Default)]
#[derive(Debug, Default, Clone)]
pub struct GetOptions {
/// Request will succeed if the `ObjectMeta::e_tag` matches
/// otherwise returning [`Error::Precondition`]
Expand Down Expand Up @@ -1291,9 +1287,11 @@ impl From<Error> for std::io::Error {
mod tests {
use super::*;
use crate::buffered::BufWriter;

use chrono::TimeZone;
use tokio::io::AsyncWriteExt;


macro_rules! maybe_skip_integration {
() => {
if std::env::var("TEST_INTEGRATION").is_err() {
Expand Down
Loading