Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial work on popcons -- close to functional #43

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Conversation

fsciortino
Copy link
Owner

@fsciortino fsciortino commented Nov 21, 2021

Adding functionality to create Plasma OPeration CONtour (POPCON) plots, based on the work of the 22.63 MIT/Princeton class of fall 2020. Adapted Open_POPCON scripts to use atomic rates from ADAS via Aurora and Hale-Bosch reactivity already coded in omfit_classes.

The script in Aurora/examples/scan_popcons.py illustrates how POPCONs can be created and can be used for testing.

Work in progress.

@anelson0528 @sfrnk

@fsciortino fsciortino marked this pull request as draft November 21, 2021 17:55
@fsciortino fsciortino self-assigned this Nov 21, 2021
@fsciortino fsciortino added enhancement New feature or request help wanted Extra attention is needed TO-DO labels Nov 21, 2021
@fsciortino
Copy link
Owner Author

@anelson0528 @sfrnk There is something funny about how profiles are being treated at the moment... and I haven't had time to deal with it yet. I've added some code that uses Aurora to find profiles of impurity charge state fractional abundances, so that the average Z for a given impurity species at each value of Te can be determined. If one sets a fixed impurity concentration value and uses these fractional abundances, then Zeff will not be flat over the radius. The code needs to be updated to deal with this.

I don't understand why functions like _P_rad are multiplied by rho at the very end. It sounds like an approximation for the specific parametrization of kinetic profiles, but I'm not sure that I follow why that's a good idea...

I'd appreciate if you could have a look and make any adjustments that you see fit. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed TO-DO
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant