Skip to content

Add separate support for xUnit v3 #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JohSand
Copy link

@JohSand JohSand commented May 28, 2025

Add simple tests

Implement xUnit testcases for xUnit.v3

@JohSand
Copy link
Author

JohSand commented May 28, 2025

fixes xUnit part of #690

The changes in xUnit are breaking, and they choose to publish a package with a different name (xUnit.v3). I believe the most reasonable way for this project is to have different nugets for FsCheck.xUnit and FsCheck.xUnit.v3.

In this I attempt the simplest possible translation of the previous implementation to the new abstractions offered in v3. It is mostly copied directly from the v2 implementation.

It suffers a bit from targeting netstandard2.0 (no task computation expression support), but I feel it is reasonable.

@kurtschelfthout
Copy link
Member

This looks great - thanks

It suffers a bit from targeting netstandard2.0 (no task computation expression support), but I feel it is reasonable.

Fwiw fine to target something more recent. E.g. FsCheck.NUnit now targets net6.0 since NUnit's latest major version update.

I'll leave this here for a bit in case you want to change that, but also happy to merge as-is.

@JohSand
Copy link
Author

JohSand commented Jun 1, 2025

Thanks for the review. I believe we can merge as-is. But it occurs to me that I made no changes to build.fsx, so no new Nuget will be published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants