FsCheck 3.0.0-rc1 XUnit Property attribute doesn't respect IAsyncLifetime

[BennieCopeland]

Test cases are executing before the InitializeAsync() method has a change to run.

[kurtschelfthout]

ok...probably we need to check for that in PropertyAttribute.

[kurtschelfthout]

Something like https://github.com/xunit/xunit/blob/v2/src/xunit.execution/Sdk/Frameworks/Runners/TestInvoker.cs#L171

[arialdomartini]

Here are a couple of unit tests (F# and C#) demonstrating the bug:

F#

module FsCheckDocSamples.Issue657

open System.Threading.Tasks
open FsCheck.Xunit
open global.Xunit

type Issue657() =

    let mutable executed = false;

    interface IAsyncLifetime with
        member _.InitializeAsync() =
            executed <- true;
            Task.CompletedTask

        member _.DisposeAsync() = Task.CompletedTask

    [<Fact>]
    member this.``InitializeAsync() is run, as a Fact``() =
        Assert.True (executed)


    [<Property>]
    member this.``InitializeAsync() is run, as a Property``() =
        Assert.True (executed)

C#

using FsCheck.Xunit;

namespace FsCheckCsharp;

public class Issue657 : IAsyncLifetime
{
    private bool Executed = false;

    public Task InitializeAsync()
    {
        Executed = true;
        return Task.CompletedTask;
    }

    Task IAsyncLifetime.DisposeAsync() => Task.FromResult(Task.CompletedTask);

    [Property(MaxTest = 1)]
    public void InitializeAsync_is_run_as_a_Property(int i)
    {
        Assert.True(Executed);
    }

    [Fact]
    public void InitializeAsync_is_run_as_a_Fact()
    {
        Assert.True(Executed);
    }
}

Both the xUnit Facts s are green; the Properties fail.