Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update everything to .NET 8 #332

Merged
merged 4 commits into from
Nov 18, 2023
Merged

Update everything to .NET 8 #332

merged 4 commits into from
Nov 18, 2023

Conversation

xperiandri
Copy link
Contributor

No description provided.

@landy @xperiandri
Update target frameworks in Bolero.Html.fsproj
aef7346 
The project file for Bolero.Html has been updated to include both .NET 6.0 and .NET 8.0 as target frameworks. This extends compatibility and support for the library across these versions.
@xperiandri
Copy link
Contributor Author

@Tarmil, @granicz looks like this error is expected
https://sl.bing.net/ghTsdC7KdeS

Source Branch: The error message mentions Action was triggered by pull_request: using SHA from head of source branch. If the action is running on a pull request from a forked repository, the token will have read-only permissions. This is a security measure on GitHub’s part.

@Tarmil
Copy link
Member

Tarmil commented Nov 16, 2023

So should we just not try to push test results from pull requests?

@xperiandri
Copy link
Contributor Author

@Tarmil try the latest fix in this branch

@xperiandri
Copy link
Contributor Author

It may help

@xperiandri
Copy link
Contributor Author

@Tarmil approve again

Tarmil
Tarmil requested changes Nov 16, 2023
View reviewed changes
src/Bolero.Server/Bolero.Server.fsproj Outdated Show resolved Hide resolved
@xperiandri
Copy link
Contributor Author

@Tarmil fixed

@xperiandri
Copy link
Contributor Author

@Tarmil @granicz approve again, please

@xperiandri
Copy link
Contributor Author

@Tarmil ping

@xperiandri
Copy link
Contributor Author

@Tarmil checks passed, your comment addressed

@Tarmil
Copy link
Member

Tarmil commented Nov 18, 2023

Thanks!

@Tarmil Tarmil merged commit 1e98ed5 into fsbolero:master Nov 18, 2023
4 checks passed
@xperiandri xperiandri deleted the net-8.0 branch November 18, 2023 08:55
@Tarmil Tarmil mentioned this pull request Nov 18, 2023
Closed
Tarmil added a commit that referenced this pull request Nov 18, 2023
@Tarmil
Backport #332: Bolero.Html on net8.0 + use .NET 8 SDK RTM
bddca8d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tarmil Tarmil Tarmil requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xperiandri @Tarmil @landy