Skip to content

Commit

Permalink
Fix shopping_list todo tests (home-assistant#103100)
Browse files Browse the repository at this point in the history
  • Loading branch information
@emontnemery @frenck
emontnemery authored and frenck committed Oct 31, 2023
1 parent 957998e commit 26b7e94
Showing 1 changed file with 31 additions and 52 deletions.
83 changes: 31 additions & 52 deletions tests/components/shopping_list/test_todo.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@

from homeassistant.components.todo import DOMAIN as TODO_DOMAIN
from homeassistant.core import HomeAssistant
from homeassistant.exceptions import HomeAssistantError

from tests.typing import WebSocketGenerator

Expand Down Expand Up @@ -115,18 +114,18 @@ async def test_get_items(
assert state.state == "1"


async def test_create_item(
async def test_add_item(
hass: HomeAssistant,
sl_setup: None,
ws_req_id: Callable[[], int],
ws_get_items: Callable[[], Awaitable[dict[str, str]]],
) -> None:
"""Test creating shopping_list item and listing it."""
"""Test adding shopping_list item and listing it."""
await hass.services.async_call(
TODO_DOMAIN,
"create_item",
"add_item",
{
"summary": "soda",
"item": "soda",
},
target={"entity_id": TEST_ENTITY},
blocking=True,
Expand All @@ -142,38 +141,18 @@ async def test_create_item(
assert state
assert state.state == "1"

# Add a completed item
await hass.services.async_call(
TODO_DOMAIN,
"create_item",
{"summary": "paper", "status": "completed"},
target={"entity_id": TEST_ENTITY},
blocking=True,
)

items = await ws_get_items()
assert len(items) == 2
assert items[0]["summary"] == "soda"
assert items[0]["status"] == "needs_action"
assert items[1]["summary"] == "paper"
assert items[1]["status"] == "completed"

state = hass.states.get(TEST_ENTITY)
assert state
assert state.state == "1"


async def test_delete_item(
async def test_remove_item(
hass: HomeAssistant,
sl_setup: None,
ws_req_id: Callable[[], int],
ws_get_items: Callable[[], Awaitable[dict[str, str]]],
) -> None:
"""Test deleting a todo item."""
"""Test removing a todo item."""
await hass.services.async_call(
TODO_DOMAIN,
"create_item",
{"summary": "soda", "status": "needs_action"},
"add_item",
{"item": "soda"},
target={"entity_id": TEST_ENTITY},
blocking=True,
)
Expand All @@ -189,9 +168,9 @@ async def test_delete_item(

await hass.services.async_call(
TODO_DOMAIN,
"delete_item",
"remove_item",
{
"uid": [items[0]["uid"]],
"item": [items[0]["uid"]],
},
target={"entity_id": TEST_ENTITY},
blocking=True,
Expand All @@ -205,20 +184,20 @@ async def test_delete_item(
assert state.state == "0"


async def test_bulk_delete(
async def test_bulk_remove(
hass: HomeAssistant,
sl_setup: None,
ws_req_id: Callable[[], int],
ws_get_items: Callable[[], Awaitable[dict[str, str]]],
) -> None:
"""Test deleting a todo item."""
"""Test removing a todo item."""

for _i in range(0, 5):
await hass.services.async_call(
TODO_DOMAIN,
"create_item",
"add_item",
{
"summary": "soda",
"item": "soda",
},
target={"entity_id": TEST_ENTITY},
blocking=True,
Expand All @@ -234,9 +213,9 @@ async def test_bulk_delete(

await hass.services.async_call(
TODO_DOMAIN,
"delete_item",
"remove_item",
{
"uid": uids,
"item": uids,
},
target={"entity_id": TEST_ENTITY},
blocking=True,
Expand All @@ -261,9 +240,9 @@ async def test_update_item(
# Create new item
await hass.services.async_call(
TODO_DOMAIN,
"create_item",
"add_item",
{
"summary": "soda",
"item": "soda",
},
target={"entity_id": TEST_ENTITY},
blocking=True,
Expand All @@ -285,7 +264,7 @@ async def test_update_item(
TODO_DOMAIN,
"update_item",
{
**item,
"item": "soda",
"status": "completed",
},
target={"entity_id": TEST_ENTITY},
Expand Down Expand Up @@ -315,9 +294,9 @@ async def test_partial_update_item(
# Create new item
await hass.services.async_call(
TODO_DOMAIN,
"create_item",
"add_item",
{
"summary": "soda",
"item": "soda",
},
target={"entity_id": TEST_ENTITY},
blocking=True,
Expand All @@ -339,7 +318,7 @@ async def test_partial_update_item(
TODO_DOMAIN,
"update_item",
{
"uid": item["uid"],
"item": item["uid"],
"status": "completed",
},
target={"entity_id": TEST_ENTITY},
Expand All @@ -362,8 +341,8 @@ async def test_partial_update_item(
TODO_DOMAIN,
"update_item",
{
"uid": item["uid"],
"summary": "other summary",
"item": item["uid"],
"rename": "other summary",
},
target={"entity_id": TEST_ENTITY},
blocking=True,
Expand All @@ -389,13 +368,13 @@ async def test_update_invalid_item(
) -> None:
"""Test updating a todo item that does not exist."""

with pytest.raises(HomeAssistantError, match="was not found"):
with pytest.raises(ValueError, match="Unable to find"):
await hass.services.async_call(
TODO_DOMAIN,
"update_item",
{
"uid": "invalid-uid",
"summary": "Example task",
"item": "invalid-uid",
"rename": "Example task",
},
target={"entity_id": TEST_ENTITY},
blocking=True,
Expand Down Expand Up @@ -443,9 +422,9 @@ async def test_move_item(
for i in range(1, 5):
await hass.services.async_call(
TODO_DOMAIN,
"create_item",
"add_item",
{
"summary": f"item {i}",
"item": f"item {i}",
},
target={"entity_id": TEST_ENTITY},
blocking=True,
Expand Down Expand Up @@ -481,8 +460,8 @@ async def test_move_invalid_item(

await hass.services.async_call(
TODO_DOMAIN,
"create_item",
{"summary": "soda"},
"add_item",
{"item": "soda"},
target={"entity_id": TEST_ENTITY},
blocking=True,
)
Expand Down

0 comments on commit 26b7e94

Please sign in to comment.