Fixed: dont colorize diff output

[james2doyle]

No description provided.

[frou]

Hi there - As far as I understand it, the git command-line program already automatically disables coloured output, because it can tell it's not outputting to a terminal. Am I missing something?

The colours we see when viewing the commit in Sublime Text are due to the "Diff" syntax highlighting being applied by the code here:

st3-gitblame/src/blame.py

Line 165 in 0de97d9

view.assign_syntax("Packages/Diff/Diff.sublime-syntax")

[james2doyle]

I'm not familiar with the internals of git, but I have a feel that a global .gitconfig that contains --color might just apply regardless. I'm also using Fish shell so maybe there is something related there where my shell ENV is being applied. I know sublime does eval $PATH so its possible there is a hiccup there too.

Anyway, here is my original output without --no-color:

You can see hidden characters in the output that stop the diff from being properly highlighted. This isnt the first time Ive encountered this issue before where there are ANSI color codes in the git diff output. I actually have a command in my terminal I wrote called strip-colors so I can copy the output of git diff and patch generation properly.

And with --no-color:

You can see the hidden characters are gone and everything highlights properly.

Regardless, I can't imagine this should cause any issues right? It sounds like the default assumption is the the output shouldn’t be colorized anyway.

What do you think?

[frou]

Thanks for elaborating - That all makes sense. I actually had to do similar to your strip-colors when making a command to reformat the output of the Elm compiler (used this library).

It'll be a couple of days before your fix makes it out to users via Package Control, because I need to sort out master and tag a new version.

[frou]

The version available via Package Control now includes this fix