Skip to content

Trim decoration to make X reachable in 80col views #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2017
Merged

Trim decoration to make X reachable in 80col views #14

merged 1 commit into from
Sep 8, 2017

Conversation

frou
Copy link
Owner

@frou frou commented Sep 6, 2017

The phantom has gotten pretty wide :)

When using Sublime with e.g. 3 side-by-side views, it was likely that the [X]s were far enough to the right that the horizontal scrollbar needed to be used to find them.

@psykzz
Copy link
Collaborator

psykzz commented Sep 8, 2017

Just to comment before i merge, i personally don't mind us taking the shortcut to just reduce the amount of text, but this could still be a problem if extra text is some how included.

Ideally we should do something smart (determine the view size and make the phantom scale), but this is a small package and the fixes can stay small.

@psykzz psykzz merged commit 6807492 into frou:master Sep 8, 2017
@frou
Copy link
Owner Author

frou commented Sep 8, 2017 via email

@frou frou mentioned this pull request Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants