GitLens like functionality

[jbrooksuk]

It'd be good if st3-gitblame could act similar to GitLens where it shows automatically for whichever line you're on.

You could also mimic some more of their functionality to show blames for different sections of code.

[psykzz]

I've never used gitlens could you give some examples? Screenshots or link to images that explain what you mean specifically?

[pvanb]

The line the cursor is on gets a blame annotation at the end of the line (the window gets extra horizontal scroll if it doesn't fit):

When hovering over the blame annotation a popup with more detail is shown:

GitLens calls it Current Line Blame.

[pvanb]

Here it is in action...

[jbrooksuk]

Thanks @pvanb I've not had time to do this.

[pvanb]

I played with this a little bit and I'm not so sure it's going to be possible. On non-blank lines using sublime.LAYOUT_INLINE for the Phantoms is fine, but on blank lines they get added before the cursor instead of after.

From the documentation:

sublime.LAYOUT_INLINE: Display the phantom in between the region and the point following.

On blank lines I guess there is effectively no region, so it gets added between the end of the previous line and the cursor? Here's a code snippet of what I'm trying:

        # get selected regions as RegionSet
        sels = view.sel()

        # get 1st cursor as Region
        region = sels[0]

        # get the current line
        line = view.line(region)

        # get row, col
        row, col = view.rowcol(region.begin())

        anchor = sublime.Region(line.end(), line.end())
        body = template.format(line=str(row), stylesheet=stylesheet)

        phantom = sublime.Phantom(anchor, body, sublime.LAYOUT_INLINE, self.on_phantom_click)
        phantoms.append(phantom)
        self.phantom_set.update(phantoms)

And here's how it behaves:

[jbrooksuk]

@wbond any ideas?

[jbrooksuk]

Could you not create a region manually?

[pvanb]

My understanding of regions is that they're based on the contents of the buffer, so I don't think you can create one outside of the bounds of the content (i.e. beyond the cursor on a blank line.) In my attempts to do so (e.g. line.end() + 1) the phantom ends up on the next line.

Hopefully I'm wrong and I'm missing something. Today was literally my first time writing Sublime plugins.

[psykzz]

I took a stab myself, but didn't get to fix the issue with the empty lines, instead I just opt to hide those lines
#27 is open for review

[jbrooksuk]

I'll try this shortly.