This repository has been archived by the owner on Dec 20, 2021. It is now read-only.
Use typecheck workaround for custom list/dicts #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #41 +/- ##
==========================================
+ Coverage 91.80% 91.84% +0.03%
==========================================
Files 12 12
Lines 2405 2404 -1
==========================================
Hits 2208 2208
+ Misses 197 196 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
As reported in python/mypy#11427, a "white lie" in typeshed messes completely the type inference for classes inheriting from ``(MutableMapping, dict)`` and ``(MutableSequence, list)``. This is a workaround that results in useful type inference.
abravalheri
force-pushed
the
fix-typecheck
branch
from
03f434c
to
a5a76be
Compare
|
Thank you very much @frostming. I am terribly sorry, I did not realise I have introduced a problematic and outdated expression in the text (English is not my first language, so I don't spot those things immediately). I removed the problematic expression from the main branch. |
abravalheri
added a commit
to abravalheri/atoml
that referenced
this pull request
Nov 2, 2021
PR frostming#41 added a workaround for the MRO type checking problem, however it missed AoT, which is fixed by this change.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in python/mypy#11427, a "lie" in typeshed messes completely the type inference for classes inheriting from
(MutableMapping, dict)and(MutableSequence, list).This is a workaround that results in useful type inference.
(Considering it is a tricky mypy issue, I suppose it will be either marked as a
wontfixor take a long time to be solved, so for the time being a workaround seems to be the best approach).