Skip to content

Fixed issue with leaky indices #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 11, 2024
Merged

Fixed issue with leaky indices #40

merged 3 commits into from
Jun 11, 2024

Conversation

fronzbot
Copy link
Owner

  • On certain inputs, the find_harmonics function would grab an index right at nfft/2 rather than aliasing it back down to 0.
  • Fix added with appropriate tests to check that situation

@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.68%. Comparing base (d637c9d) to head (98269f7).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #40      +/-   ##
==========================================
+ Coverage   65.82%   67.68%   +1.86%     
==========================================
  Files           4        4              
  Lines         158      164       +6     
==========================================
+ Hits          104      111       +7     
+ Misses         54       53       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fronzbot fronzbot merged commit e7d90fd into dev Jun 11, 2024
7 checks passed
@fronzbot fronzbot deleted the fix-leak-index branch June 11, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants