Skip to content

PR #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

bhague1281
Copy link
Contributor

Week 3 HW Submission

Please fill out the information below in order to complete your assignment. Feel free to update this comment later if necessary.

  • Comfort rating on this assignment (1-5): 1|2|3|4|5
  • Completion rating on this assignment: complete|incomplete

Copy link
Contributor Author

@bhague1281 bhague1281 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments:

  • I recommend using one file per component. It makes the code easier to read and organize.
  • Your cart currently removes all instances of a particular rental if one is clicked... even though duplicates are allowed. While this is ok, I would look into keeping the cart behavior consistent (such as not allowing duplicates to be added).
  • I think your .gitignore is misconfigured because the entire node_modules folder got committed to Github. You'll want to avoid that in the future.

Great job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants