week3 ✅ #11
Open
week3 ✅ #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhague1281
reviewed
May 10, 2022
|
|
||
| // Determine whether to display the "★ Member preview" element. | ||
| const memberPreviewClasses = | ||
| memberPreview ? "member-preview" : "member-preview hidden"; |
Contributor
There was a problem hiding this comment.
I haven't seen the use of CSS for hiding/showing these elements before. Nice job.
bhague1281
reviewed
May 10, 2022
|
|
||
| ArticleContent.propTypes = { | ||
| title: PropTypes.string.isRequired, | ||
| description: PropTypes.string, |
Contributor
There was a problem hiding this comment.
Nitpick: This could probably be required. I think one description is an empty string, but that's still a string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Week 2 HW Submission
Please fill out the information below in order to complete your assignment. Feel free to update this comment later if necessary.