Skip to content

finished #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/components/DivElement.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,18 @@
// Import HTMLElement here
import HTMLElement from './HTMLElement';

// Define class here
class DivElement extends HTMLElement {
constructor(content) {
super();
super.tag = 'div';
this.content = content;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another way of doing this would be:

constructor(content) {
  super('div', content);
}

}

render() {
return super.render();
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another way of doing this would be omitting the render function completely. Since the class instance inherits from HTMLElement, it'll be able to access the parent's render function.

}

// Export class here
export default DivElement;
13 changes: 12 additions & 1 deletion src/components/HTMLElement.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,15 @@
// Define class here

class HTMLElement {
constructor(tag, content) {
this.tag = tag;
this.content = content;
}

render() {
return `<${this.tag}>${this.content}</${this.tag}>`;
}
}

// Export class here
export default {};
export default HTMLElement;
18 changes: 11 additions & 7 deletions src/rolodex/rolodexPrinter.js
Original file line number Diff line number Diff line change
@@ -1,11 +1,15 @@
import people from './people.json';

people.forEach(function (person) {
const names = person.name.split(' ');
const firstName = names[0];
const lastName = names[1];
const email = person.email;
const phone = person.phone;
people.forEach((person) => {
const { name } = person;
const { email, phone } = person;
const [firstName, lastName] = name.split(' ');

console.log('First name: ' + firstName + '\nLast name: ' + lastName + '\nEmail: ' + email + '\nPhone number: ' + phone + '\n');
console.log(
`First name: ${firstName}
Last name: ${lastName}
Email: ${email}
Phone number: ${phone}
`,
);
});
29 changes: 16 additions & 13 deletions src/timer/Timer.js
Original file line number Diff line number Diff line change
@@ -1,17 +1,20 @@
function Timer(seconds) {
this.seconds = seconds;
}
class Timer {
constructor(seconds) {
this.seconds = seconds;
}

start() {
console.log(this.seconds);

Timer.prototype.start = function () {
var instance = this;
var timerInterval = setInterval(function () {
if (instance.seconds === 0) {
clearInterval(timerInterval);
}
const timerInterval = setInterval(() => {
if (this.seconds === 0) {
clearInterval(timerInterval);
}

console.log(instance.seconds);
instance.seconds -= 1;
}, 1000);
};
console.log(this.seconds);
this.seconds -= 1;
}, 1000);
}
}

export default Timer;