-
Notifications
You must be signed in to change notification settings - Fork 19
Added all HW Responses #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,15 @@ | ||
// Import HTMLElement here | ||
import HTMLElement from './HTMLElement'; | ||
|
||
// Define class here | ||
class DivElement extends HTMLElement { | ||
constructor(content) { | ||
super('div', content); | ||
} | ||
} | ||
|
||
// let div1 = new DivElement('test'); | ||
// console.log(div1); | ||
// console.log(div1.render()); | ||
// Export class here | ||
export default DivElement; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,18 @@ | ||
// Define class here | ||
class HTMLElement { | ||
constructor(tag, content) { | ||
this.tag = tag; | ||
this.content = content; | ||
} | ||
|
||
render() { | ||
return `<${this.tag}>${this.content}</${this.tag}>`; | ||
} | ||
} | ||
|
||
// const p = new HTMLElement('p','heyyyy'); | ||
// console.log(p.render()); | ||
|
||
// console.log(p); | ||
// Export class here | ||
export default {}; | ||
export default HTMLElement; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,23 @@ | ||
import people from './people.json'; | ||
|
||
const{name, email, phone} = person; | ||
|
||
people.forEach(function (person) { | ||
const names = person.name.split(' '); | ||
const firstName = names[0]; | ||
const lastName = names[1]; | ||
const email = person.email; | ||
const phone = person.phone; | ||
firstName = person.name; | ||
lastName = person.name; | ||
email = person.email; | ||
phone = person.phone; | ||
|
||
console.log('First name: ' + firstName + '\nLast name: ' + lastName + '\nEmail: ' + email + '\nPhone number: ' + phone + '\n'); | ||
console.log(`First name:${firstName}\nLast name:${lastName}\nEmail:${email}\nPhone number:${phone}\n' `); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Template literal looks good. |
||
}); | ||
|
||
// people.forEach(function (person) { | ||
// const names = person.name.split(' '); | ||
// const firstName = names[0]; | ||
// const lastName = names[1]; | ||
// const email = person.email; | ||
// const phone = person.phone; | ||
|
||
// console.log('First name: ' + firstName + '\nLast name: ' + lastName + '\nEmail: ' + email + '\nPhone number: ' + phone + '\n'); | ||
// }); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. To get this working, you can just use this code + replace the
Hopefully that helps. |
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,17 +1,30 @@ | ||
function Timer(seconds) { | ||
this.seconds = seconds; | ||
class Timer { | ||
constructor(seconds) { | ||
this.seconds = seconds; | ||
} | ||
|
||
start() { | ||
const timerInterval = setInterval(() => { | ||
if (this.seconds === 0) { | ||
clearInterval(timerInterval); | ||
} | ||
|
||
console.log(this.seconds); | ||
this.seconds -= 1; | ||
}, 1000); | ||
} | ||
} | ||
|
||
Timer.prototype.start = function () { | ||
var instance = this; | ||
var timerInterval = setInterval(function () { | ||
if (instance.seconds === 0) { | ||
clearInterval(timerInterval); | ||
} | ||
// Timer.prototype.start = () => { | ||
// let instance = this; | ||
// let timerInterval = setInterval( () => { | ||
// if (instance.seconds === 0) { | ||
// clearInterval(timerInterval); | ||
// } | ||
|
||
console.log(instance.seconds); | ||
instance.seconds -= 1; | ||
}, 1000); | ||
}; | ||
// console.log(instance.seconds); | ||
// instance.seconds -= 1; | ||
// }, 1000); | ||
// }; | ||
|
||
export default Timer; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
person
is out of scope here, so this will cause an error because the variable is not defined.