Check if element exists before updating model view #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
why wouldn't this be merged, it's been causing Sentry errors for us and it's a simple fix instead of forking and adding it ourselves |
|
@stefanneculai Any chance of getting this merged and released? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
We found a small issue with the model view update. Right now, when the
contentChangedevent fires, the model view is updated asynchronously. However, in come cases the update is performed after the element is destroyed, leading to the following error:(caused here: https://github.com/froala/angular-froala/blob/master/src/angular-froala.js#L172)
In our case, this error happens when the user activates code view and then presses the back button of their browser.
I implemented a simple fix by checking if the element still exists before updating.
It would be great if this gets merged. Thanks!