Fixed linkage errors on macOS #3870
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
KjellMorgenstern
force-pushed
the
fix-bad-mac-build
branch
from
a98bf60 to
810ea75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linkage for macOS is specified in a strange and non-standard way in the .pro files, which makes it brittle. This caused it not to work on my system. These changes switch from using the "-l" option with absolute system paths to using the "-framework" option to include frameworks. Additionally, libz was included twice with "-lz" and with an absolute path. I removed the absolute path, as we don't need to copies and "-lz" is more general.