Deselect all items before exporting an image to PNG or JPG. Fixes #3712 #3723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👉 View analysis in DeepCode’s Dashboard | Configure the bot |
|
Deselecting all items might be an unwanted effect. Do you see an easy way to preserve the users selection over the export? Or better, just not render that rectangles during the export? |
|
Now we deselect the items that are selected and after the export we select them again. Interestingly, this also fixes #3073 (the label of the resistor is exported well) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The items are deselected, but they can be still be seen as selected in the app. After the screen is refreshed (f. ex. by zooming in the app or moving a component), they are shown correctly.