remove need for hard-coded boost path with unit tests #3660
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that the existing unit test
.pro
files had boost_1_70_0 hard-coded for the boost environment. That broke for me, since boost_1_72_0 is being used locally. Trying to get generic detection to work, so that the same boost environment (detection logic) would be used for both phoenix and the unit tests, I discovered that the relative path detected and used by pri/boostdetect.pri did not work for the unit tests. The folder nest level paths do not match the detected path.I created a new boostdetect version (near rewrite) that takes an optional flag to generate an absolute path. An older version of pri/boostdetect.pri was unconditionally setting an absolute path. That was changed to relative at the same time that the detection search was expanded to look for the boost environment folder in src/lib. Although I see that .gitignore was NOT adjusted to ignore a boost folder in src/lib.
This needs testing with a windows build. I do not have an environment available to do that. Some of the information seen says project and pri files are handled a bit differently on windows, using resource files for some things instead. With this version, phoenix.pro works with or without
absolute_boost = 1
. Without uses the same relative path as previously.