fix bad part hangs Fritzing bug #3388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will this change notice the user about the corrupted part? While it is desirable not to crash, leaving an corrupted part unnoticed might be even worse. What might have caused the corruption in the first place? |
|
Yes it would alert the user that the part is corrupted. However since development has died, at this point it is moot unless we can restart development Iwhich some of us are trying to do).The corruption is caused by creating improperly formatted fzp or svg files (which is easy to do by accident). As you will likely see this pull request has not been acted on as development (and thus releases) have stopped. Peter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code seems to fix issue #3382 where a corrupted fzp file causes a seg fault in Fritzing and leaves the parts files around after the crash. While I don't know what I'm doing and just copied a section of code that deals with a similar situation and it would be good to have someone familiar with the code review this, since the alternative is a seg fault and a hang, I don't see that this fix could be worse.
Peter