Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to choose installed translations using LINGUAS #3252

Merged
merged 1 commit into from
Mar 31, 2017

Conversation

cjmayo
Copy link
Contributor

@cjmayo cjmayo commented Jul 6, 2016

Saves a lot of code in downstream packaging with selected translations only e.g.:
gentoo/gentoo@53c8431#diff-13ffa73c7e68e1ac2f92e7aa89c68cc2R50

@cjmayo
Copy link
Contributor Author

cjmayo commented Jul 8, 2016

Maybe L10N isn't the best choice of name for the variable as the language names are in "language_country" form - with the country in lower case. And if they really are just translations and not conversion of units etc.

Any particular reason for the lower case country suffixes? (FApplication::findTranslator)

Selfishly BCP47 format with hyphens and upper case region subtag would be easier to handle. But I guess changing it could break a user's saved configuration.

@cjmayo
Copy link
Contributor Author

cjmayo commented Aug 19, 2016

I think LINGUAS Is better, typically uses underscores instead of hyphens.

Upper case country codes would be great but easily converted with ${LINGUAS,,}

@cjmayo cjmayo changed the title add option to choose installed translations using L10N add option to choose installed translations using LINGUAS Aug 19, 2016
@el-j el-j merged commit aaa338c into fritzing:master Mar 31, 2017
@cjmayo cjmayo deleted the l10n branch February 2, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants