use MIME database XML file and install_fritzing.sh #3231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces individual MIME type files which are created by update-mime-database. https://specifications.freedesktop.org/shared-mime-info-spec/shared-mime-info-spec-latest.html Install with install_fritzing.sh and phoenix.pro generated Makefile.
Provides desktop menu entry and MIME associations.
|
That's great, thanks! I You're obviously much more versed in this than any of us (we only occasionally run Ubuntu in a virtual box). So you're welcome to take this further. If the mime.types code isn't required as far as you're aware of, let's remove it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started this because I wanted to propose that a single fritzing.xml MIME database file is better to manage and package. Then realised it would break install_fritzing.sh, and ended up suggesting a number of changes to that.
Comments on individual commits.
I was tempted to include removing the
~/.mime.typescode. But maybe it was installed with a particular desktop environment or window manager in mind?