Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: Images on copper layers missing from gerbers #3807

Closed
deshipu opened this issue Apr 7, 2021 · 3 comments
Closed

regression: Images on copper layers missing from gerbers #3807

deshipu opened this issue Apr 7, 2021 · 3 comments

Comments

@deshipu
Copy link

deshipu commented Apr 7, 2021

Current Behaviour

In Fritzing 0.9.6 and 0.9.5, images placed on the copper layer do not appear in generated Gerbers:
fritzing096

In earlier versions (0.9.3 is what I tested), the images appear correctly:
fritzing093

**Build:** Version 0.9.6

Operating System:
Linux

Steps to reproduce:
Create a PCB with an image on a copper layer.
Export the PCB as gerbers.
See the image missing from the exported gerbers.

Expected Behaviour

The image should be included in the exported gerbers.

@KjellMorgenstern
Copy link
Member

Confirmed.
I tested by exporting a production PDF of the Ocarina v1 on hackaday, which users similar images.
0.9.4 has the pattern on copper top
0.9.6 does not have the pattern

@deshipu
Copy link
Author

deshipu commented Apr 8, 2021

If that helps, I also noticed that if you re-do the ground fills, it ignores the images in 0.9.5 and 6, while it goes around them in 0.9.3.

@KjellMorgenstern
Copy link
Member

KjellMorgenstern commented Apr 14, 2021

This is resolved by adding 'e' and 'E' to svg token list. It is not a svg path command, but it is used (and valid svg) in scientific notation of numbers. Patch upcoming.

@KjellMorgenstern KjellMorgenstern added this to the 0.9.7 milestone Apr 14, 2021
KjellMorgenstern added a commit that referenced this issue Sep 24, 2021
Silence empty polyline assertion

Replace arg(QString).arg(QString) with arg(QString, QString)
Fix more warnings

Upload to fab, happy flow passes

Fix build warning on windows

Refactor renderthing into own file

Fix quirk with disabled rotate and align submenus

addToBin now also re-enabled

Always center mouse when draging from the parts bin.

Fixes some quirks with rapid mouse movement or when leaving and re-entering the window.

Fixed #3807 without breaking #3647 by fixing svg lexer float exponent separation bug.

Added simplified unit test case for pathlexer clean of float exponents aka #3807.

Fix some Qt5.12 deprecations

Fix unused variable

weightmap was not used

refer fritzing.org with TLS in generator

Implement missing fzp drag and drop support

Fix error message

Bump up version to 0.9.7b

Fix issue: Mystery part terminal points disapeared

Fixed routing menu problem: alt-r now only has to be pressed once.

Fix issue #3839 . If file can not be loaded, allow empty (null) itemBase

Fix issue #3838. Do not add part if part is null

Fix #3833, use darker background for dropdowns in code editor

Fix about box text color for dark themes

Moved setTitle so it is also executed for the welcome view.

Fixed warning about unused variable in autoroute panelizer.

Fixed warning about unused variable in items partfactory.

Fixed warning about unused variable in items ruler.

Fixed warning about unused variable in kicad module.

Fixed warning about unused typedef in graph utils.

Changed clickable labels into push buttons to allow operation by keyboard.

Fix some english errors

NULL -> nullptr

Fix QtSplitBehavior deprecation warning

Fix QFlags warnings

Fix qt deprecation warnings

Replace hard to understand access to first item, use empty instead of count == 0

Flatten condition tree, avoid NULL

Preferences color labels now have both correct color and text after change.

Made preferences dialog fit on a laptop screen with 768 vertical resolution.

Translated using Weblate (German)

Currently translated at 99.4% (1793 of 1803 strings)

lupdate phoenix.pro

Gerber: Inherit stroke-width from parent objects

Fix parsing release date, ok button opens update in browser. Do not
search for part updates.

Seraching for part updates is a frequent source of error,
and introduces a dependency to github. Fritzing might
hang during start if github does not answer. Also their
service is quite reliable, we can not assume it for
granted (and free).
With a higher release frequency of Fritzing, there also
is less need for part updates. Note: We still use git,
and users who wish can directly work on the git repo
for parts, for example call 'git pull' to update the
parts manually.

Fixed bug that caused schematic logos to disappear in svg image exports.

Fix include for MSVC2019

Remove Snootlab from order, add Spresense
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants