Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

component updates: handles when list is empty and handles async loading of list #108

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

csantiago132
Copy link

This PR adds a couple of updates to the component;

** Changes/Updates:**

  • list of members are loaded from local state instead of props; this makes async loading and updating the list easier and automatically

New:

  • adds a prop to display when the list is empty instead of displaying nothing
  • adds a slot emptyList to display any custom component when list is empty

Breaking changes:

  • members prop got changed to list-members this is because the code is so couple to 'members' prop that its easier to change a prop instead of the whole codebase

@csantiago132
Copy link
Author

can solve #106 and #100

@fritx
Copy link
Owner

fritx commented Sep 4, 2019

Thanks, just wait for my test case being ready and once the test passed in all cases I can merge it.

@csantiago132
Copy link
Author

@fritx ok thanks for taking the time to review it!

@mirkos93
Copy link

Any update regarding the merge of this pull request?
Thank you

@fritx
Copy link
Owner

fritx commented Sep 15, 2020

@mirkos93 @csantiago132 sorry I can not merge the PR directly as it breaks the interface to users (for example, the prop is renamed)

mirkos93 pushed a commit to mirkos93/vue-at that referenced this pull request Sep 15, 2020
@fritx fritx added the declined label Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants