Fix main PHPSpec and PHP 8.4 compatibility: Wrap service container arrays in objects #64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extension fails on PHP 8.4 with a TypeError when PhpSpec's IndexedServiceContainer::get() method expects an object return type but receives an array. This is due to stricter type enforcement in PHP 8.4.
Error:
PhpSpec's service container has a strict return type declaration of object for the get() method, but two services were returning arrays directly:
code_coverage.options
- returned configuration arraycode_coverage.reports
- returned reports arrayIntroduced wrapper classes to encapsulate arrays while maintaining backward compatibility:
CodeCoverageOptions
ClassCodeCoverageReports
Class