Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: address Awesome.re comments #9

Merged
merged 1 commit into from
Jul 28, 2021

Conversation

pgray-hiro
Copy link

This PR fixes remaining issues identified during the Awesome.re PR process. You can review comments here. The primary suggestions were:

  • Change title from Stacks Chain to Stacks for consistency with the project. He is not concerned with the naming collision between this and the Awesome Stacks related to tech stacks.
  • Consistency and correctness in naming - STX, Bitcoin, Lightning Network, TypeScript, JavaScript were all identified as either not consistent or not correctly formed.
  • Update the introduction text to include a link to the Stacks website (I put it to the What is Stacks page, because if we link to the root of the site we get an awesome-lint error for having the same link twice.
  • Update the introduction text to include more context on what Stacks is and why it's cool.

In addition to these suggestions, I modified 2 of our section headings. I've been reviewing other Awesome lists and it isn't common to see the word "Awesome" in the section headings - just the title of the list. While this change wasn't specifically requested, I think it's an improvement and makes our list more similar to other lists that have already been included.

@friedger friedger merged commit 86f94a0 into friedger:main Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants