mkdex: Fix field item ordering (#322)

To match what dex_file_verifier.cc does. Fixes #296.
frida · Jun 6, 2024 · a635d2d · a635d2d
1 parent 3dc627b
commit a635d2d
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/lib/mkdex.js b/lib/mkdex.js
@@ -655,6 +655,7 @@ function computeModel (classes) {
       stringToIndex[fieldName]
     ];
   });
+  fieldItems.sort(compareFieldItems);
 
   const methodItems = methods.map(method => {
     const [klass, protoId, name, annotationsId] = method;
@@ -744,7 +745,7 @@ function computeModel (classes) {
     const instanceFields = fieldItems.reduce((result, field, index) => {
       const [holder] = field;
       if (holder === classIndex) {
-        result.push([index, kAccPublic]);
+        result.push([index > 0 ? 1 : 0, kAccPublic]);
       }
       return result;
     }, []);
@@ -848,6 +849,21 @@ function compareProtoItems (a, b) {
   return 0;
 }
 
+function compareFieldItems (a, b) {
+  const [aClass, aType, aName] = a;
+  const [bClass, bType, bName] = b;
+
+  if (aClass !== bClass) {
+    return aClass - bClass;
+  }
+
+  if (aName !== bName) {
+    return aName - bName;
+  }
+
+  return aType - bType;
+}
+
 function compareMethodItems (a, b) {
   const [aClass, aProto, aName] = a;
   const [bClass, bProto, bName] = b;

diff --git a/test/re/frida/ClassCreationTest.java b/test/re/frida/ClassCreationTest.java
@@ -321,6 +321,7 @@ public void classWithUserDefinedFieldsCanBeImplemented() throws ClassNotFoundExc
                 "  fields: {" +
                 "    lastInt: 'int'," +
                 "    lastStr: 'java.lang.String'," +
+                "    lastByteArr: '[B'," +
                 "  }," +
                 "  methods: {" +
                 "    format: [{" +