Open
Conversation
Member
|
That's a lot of code...anyway, verify with @nuxttux that everything is working as expected, then let's look at the code :) |
Author
|
As commented in #707 (comment), I'm adding an extra fix to let move groups of parents without moving children... Friction does it this way so it might be the best way to do less harm while fixing the odd behaviors, @rodlie it's your decision to choose the new "strict" parenting mode or go for a softer one as I proposed with this last commit. Here is a new project to test this situation parent_influences_v04.friction.zip BTW, it probably still needs to be tested under more circumstances... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After fighting with #707 issue, I ended up doing it with help of AI as the original implementation had some things I didn't like at all (apart from those strange behaviors) and because doing a "parent effect" is doable but adding influences elevates the complexity too much for my skills.
The code includes some special situations that needed special code such as being able to edit the child object (the object with the effect) transform and keep the relationship right and so many more... I hope this is not an inconvenience. In the way I added a visual line that connects the child with the parent when the child is selected, it doesn't change versions so it's safe for v1.0.
I hope you like it!
I'm including here my test file in case you want to test the feature, I'm probably mission more situations that I didn't test so it would be necessary to have a look at them all to verify the new code.