Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimiser relic exclusion filter #481

Open
wants to merge 18 commits into
base: beta
Choose a base branch
from

Conversation

FI00ds
Copy link
Contributor

@FI00ds FI00ds commented Jul 12, 2024

Pull Request

Description

  • Added a per-relic filter which is toggleable, accessed via the relic modal, which allows the user to restrict which characters can use the relic in the optimiser tab
  • Added a display and filter option in the relics tab to filter/see which relics have their filter set to active/inactive
  • Added a toggle in the optimiser options to bypass the per-relic wearer restrictions
  • Updated the optimizer options tooltip with the description of the new option + made names and order consistent with the display

Not over the world with the icons but I can't think of anything that really fits

Related Issue

Checklist

  • I have added commit messages that are descriptive and meaningful.
  • I have tested the changes locally.
  • I have reviewed the code changes.

Screenshots

Updated relic tab

firefox_2024-07-15_15-26-08

Updated optimizer options panel and tooltip

firefox_2024-07-12_17-47-16firefox_2024-07-12_17-48-19

Display on relic preview

firefox_2024-07-15_15-28-38

Selection + Toggle in RelicModal

firefox_2024-07-22_16-10-03
firefox_2024-07-22_16-11-40

@FI00ds FI00ds changed the title feature: relic lock exclude feat: optimiser relic exclusion filter Jul 17, 2024
@fribbels
Copy link
Owner

fribbels commented Aug 6, 2024

Holding onto this one for a bit, after trying it out it feels pretty unintuitive to use, and I suspect it might be misused by people & they'll not understand why relics aren't showing up when they should be. Probably needs a discussion about what the most user friendly way to do this is

@FI00ds FI00ds changed the base branch from beta to main August 20, 2024 17:48
@FI00ds FI00ds changed the base branch from main to beta August 20, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Relic locking / exclusion filter
3 participants