-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: optimiser relic exclusion filter #481
Open
FI00ds
wants to merge
18
commits into
fribbels:beta
Choose a base branch
from
FI00ds:feature/relic-lock-exclude
base: beta
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add text for restriction bypass re-order to be consistent with display order make names consistent
…s/hsr-optimizer into feature/relic-lock-exclude
FI00ds
changed the title
feature: relic lock exclude
feat: optimiser relic exclusion filter
Jul 17, 2024
Holding onto this one for a bit, after trying it out it feels pretty unintuitive to use, and I suspect it might be misused by people & they'll not understand why relics aren't showing up when they should be. Probably needs a discussion about what the most user friendly way to do this is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Not over the world with the icons but I can't think of anything that really fits
Related Issue
Checklist
Screenshots
Updated relic tab
Updated optimizer options panel and tooltip
Display on relic preview
Selection + Toggle in RelicModal