Check for termination file before starting #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Based on the edge case that we seem to have discovered, this should do the job and is simple. |
|
Thanks @patrickmariglia! This could work for sure. I was thinking the other way around: writing a pid-file after the signal handlers are registered and have the pre stop hook wait for the pid-file to exist. I don't have a preference when we know it works. |
A workaround to be sure, but I've written worse code. This adds a file `/tmp/sparkplug_ready` after sparkplug has registered its signal handlers. This gives workloads running in kubernetes the ability to check for this file before sending a signal to terminate. While #42 did add a signal handler to make sure sparkplug exits _after_ processing a message, there are extremely rare situations where kubernetes sends a TERM signal before sparkplug registers it's signal handler. In these situations, the TERM is swallowed up and eventually a KILL is executed at an arbitrary time, causing issues.
patrickmariglia
force-pushed
the
check-for-file
branch
from
168e130
to
39c2d8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A workaround to be sure, but I've written worse code.
This adds a file
/tmp/sparkplug_readyafter sparkplug has registeredits signal handlers. This gives workloads running in kubernetes the
ability to check for this file before sending a signal to terminate.
While #42 did add a signal
handler to make sure sparkplug exits after processing a message,
there are extremely rare situations where kubernetes sends a TERM
signal before sparkplug registers it's signal handler. In these situations,
the TERM is swallowed up and eventually a KILL is executed at an
arbitrary time, causing issues.