Document release process #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeanWay
reviewed
Jul 11, 2019
| @@ -9,11 +9,16 @@ Sparkplug is a lightweight AMQP message consumer. It allows you to specify queue | |||
| run tests with `nosetests` | |||
|
|
|||
| ## Releasing | |||
| We release two versions: One to the FreshBooks internal PyPI repository, and one to the public repository. | |||
There was a problem hiding this comment.
If the pypi release process works and is documented, why maintain both? We use many other python packages internally that don't get pushed directly to our private index, why should it be different for open source projects we maintain?
There was a problem hiding this comment.
Maintaining both I believe his more of a historical artifact. I don't see why we can't rip out pushing to the internal PyPI repository. Will you up for doing so @DeanWay? I wanted to document what existed as of today
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.