-
Notifications
You must be signed in to change notification settings - Fork 17
Update frequenz-api-microgrid
to v0.15.1
#416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
aba0576
74a9b92
be64e00
1638430
f3e3d41
f1203d4
228c6c4
c103d1c
4708546
1fffefa
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,10 +12,13 @@ | |
from enum import Enum | ||
from typing import Iterable, Optional, Set, TypeVar, Union | ||
|
||
# pylint: disable=no-name-in-module | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Any ideas why is this suddenly failing? It would be good to find out where this regressions comes from (and ideally fix it) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yes, I'm guessing because some protobuf dep version changed in the api repo. That's why I put them all in a single comment, so it can be removed easily once we figure out the issue 🤞🏽 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I actually have a theory now: Pylint doesn't look at the type annotations, it just looks at the code other other modules to see if the desired functions are there. This works only if the names are defined in python code in the modules. But protoc has not been doing that for a while now, and is just using dynamic module creation during import, and we appear to have to just use the type hints to know what's going on. If you look at one of the generated files, this becomes clear, like And it was working until now, because we were using a very old version of protoc in the api repo. |
||
from frequenz.api.microgrid.battery_pb2 import ComponentState as BatteryComponentState | ||
from frequenz.api.microgrid.battery_pb2 import RelayState as BatteryRelayState | ||
from frequenz.api.microgrid.common_pb2 import ErrorLevel | ||
from frequenz.api.microgrid.inverter_pb2 import ComponentState as InverterComponentState | ||
|
||
# pylint: enable=no-name-in-module | ||
llucax marked this conversation as resolved.
Show resolved
Hide resolved
|
||
from frequenz.channels import Receiver, Sender | ||
from frequenz.channels.util import Timer, select, selected_from | ||
|
||
|
Uh oh!
There was an error while loading. Please reload this page.