Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove methods that were moved to client repo #82

Merged
merged 8 commits into from
Dec 4, 2024
Merged

Remove methods that were moved to client repo #82

merged 8 commits into from
Dec 4, 2024

Conversation

Marenz
Copy link
Contributor

@Marenz Marenz commented Dec 2, 2024 •
edited
Loading

The PR looks large, but most commits are just small changes. Tried to keep it well separated.

@Marenz Marenz requested a review from a team as a code owner December 2, 2024 14:02
@github-actions github-actions bot added part:docs Affects the documentation part:tests Affects the unit, integration and performance (benchmarks) tests part:actor Affects the dispatching actor part:dispatcher Affects the high-level dispatcher interface labels Dec 2, 2024
@Marenz Marenz marked this pull request as draft December 2, 2024 14:22
@Marenz Marenz force-pushed the remclean branch 2 times, most recently from 2d28695 to 6782f52 Compare December 3, 2024 17:31
@github-actions github-actions bot added the part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) label Dec 3, 2024
@Marenz Marenz marked this pull request as ready for review December 3, 2024 17:34
Marenz added 4 commits December 3, 2024 19:20
@Marenz
Remove methods that were moved to client repo
169d97b 
* The `running` property was renamed to `started`
* The running state was removed

Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
@Marenz
Remove unused dependency dateutil
bcf3d95 
The modules were moved to client-dispatch

Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
@Marenz
Fix formatting in pyproject
5e2c123 
Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
@Marenz
Remove unused RunningState Sent tracking
f65bed5 
Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
@Marenz
Mark dispatch as deleted only in the update function.
9345acd 
This makes the code cleaner.

Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
llucax
llucax previously approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@llucax llucax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bye bye RunningState.DIFFERENT_TYPE, you will not be missed 🤣 ❤️

@Marenz
Copy link
Contributor Author

Marenz commented Dec 4, 2024

bye bye RunningState.DIFFERENT_TYPE, you will not be missed

I missed it already, tbh. Now you have to make double-sure you check for the .type before looking at running. Already missed one occasion for that before that I luckily found later.

Still not convinced this is a better interface that leads to less errors.

@Marenz Marenz added this pull request to the merge queue Dec 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 4, 2024
@Marenz Marenz added this pull request to the merge queue Dec 4, 2024
@Marenz
Copy link
Contributor Author

Marenz commented Dec 4, 2024

Maybe the receiver should come pre-filtered for a set of types you specify 🤔

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 4, 2024
@Marenz Marenz added this pull request to the merge queue Dec 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 4, 2024
@Marenz Marenz added this pull request to the merge queue Dec 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 4, 2024
@Marenz Marenz added this pull request to the merge queue Dec 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 4, 2024
@Marenz Marenz enabled auto-merge December 4, 2024 17:33
Marenz added 3 commits December 4, 2024 18:35
@Marenz
Add type information to member variable
50988d7 
Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
@Marenz
Remove outdated part of documentation
4121f29 
Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
@Marenz
Lower CI timeout to expected runtime for faster failures
4b63715 
Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
@Marenz Marenz disabled auto-merge December 4, 2024 17:36
@Marenz Marenz merged commit 4220f2c into frequenz-floss:v0.x.x Dec 4, 2024
10 checks passed
@Marenz Marenz deleted the remclean branch December 4, 2024 17:36
@Marenz Marenz mentioned this pull request Dec 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llucax llucax llucax left review comments

@stefan-brus-frequenz stefan-brus-frequenz Awaiting requested review from stefan-brus-frequenz stefan-brus-frequenz is a code owner automatically assigned from frequenz-floss/api-dispatch-team

Assignees
No one assigned
Labels
part:actor Affects the dispatching actor part:dispatcher Affects the high-level dispatcher interface part:docs Affects the documentation part:tests Affects the unit, integration and performance (benchmarks) tests part:tooling Affects the development tooling (CI, deployment, dependency management, etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Marenz @llucax