-
Notifications
You must be signed in to change notification settings - Fork 6
Closed
Labels
part:clientAffects the client codeAffects the client codepart:toolingAffects the development tooling (CI, deployment, dependency management, etc.)Affects the development tooling (CI, deployment, dependency management, etc.)type:enhancementNew feature or enhancement visitble to usersNew feature or enhancement visitble to users
Milestone
Description
What's needed?
This dependency alone is 50MB and also depends on multiple big libraries, like numpy, which in itself is another 16MB.
All of this is for the remote possibility that someone would want to know the timezone of a particular microgrid, which seems a bit bloated.
On top of that, because of the size bloat, it seems like the package doesn't provide pre-built binaries (at least for ARM) in PiPy anymore.
Proposed solution
- Remove the
timezonefinderdependency - Stop attempting to find out the timezone of a microgrid when the timezone doesn't come in the protobuf message and just allow having a
Nonetimezone - Document the change of behaviour and dependencies in the release notes. Recommend users installing
timezonefinderthemselves if they need to get a timezone from the coordinates (with a small example). Clarify this change is shipped in a patch release even if there is a breaking change because this feature have no known users.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
part:clientAffects the client codeAffects the client codepart:toolingAffects the development tooling (CI, deployment, dependency management, etc.)Affects the development tooling (CI, deployment, dependency management, etc.)type:enhancementNew feature or enhancement visitble to usersNew feature or enhancement visitble to users