Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new BaseClient version #109

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Use new BaseClient version #109

merged 2 commits into from
Nov 19, 2024

Conversation

Marenz
Copy link
Contributor

@Marenz Marenz commented Nov 18, 2024

  • Reset release notes after release
  • Update dependency frequenz-client-base to 0.8.0

Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
@github-actions github-actions bot added part:docs Affects the documentation part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) part:test-utils Affects the test utilities part:dispatcher labels Nov 18, 2024
@Marenz Marenz changed the title Use new BaseClient verison Use new BaseClient version Nov 18, 2024
@Marenz Marenz added the status:blocked Other issues must be resolved before this can be worked on label Nov 18, 2024
@Marenz Marenz marked this pull request as ready for review November 19, 2024 12:57
@Marenz Marenz requested review from a team as code owners November 19, 2024 12:57
@Marenz Marenz enabled auto-merge November 19, 2024 12:58
Comment on lines -41 to 42
"frequenz-client-base >= 0.7.0, < 0.8.0",
"frequenz-client-base >= 0.8.0, < 0.9.0",
"frequenz-client-common >= 0.1.0, < 0.3.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't you update RELEASE_NOTES?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I usually update them if it's something the user can see, but nothing changed from their perspective in this case, just an indirect dependency

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the only issue with bumping dependencies with breaking changes is users are forced to upgrade the dependency too (the thing that is triggering all these release trains), which will force them to update the code because the changes are breaking. This is why we usually document disruptive dependency bumps, because it has a high potential of actually affecting the user at the end. But in development mode (v0.x.x) I think is not that bad if it is missing in the release notes, people are supposed to expect breakage anyway.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair

Copy link
Contributor

@llucax llucax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question as Ela, otherwise LGTM. Feel free to merge if you add notes or you think notes are not necessary because you plan to invalidate the previous version or something.

Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
@Marenz Marenz disabled auto-merge November 19, 2024 14:04
@Marenz Marenz merged commit 636d4cb into frequenz-floss:v0.x.x Nov 19, 2024
14 checks passed
@Marenz Marenz deleted the new-base branch November 19, 2024 14:04
github-merge-queue bot pushed a commit to frequenz-floss/frequenz-dispatch-python that referenced this pull request Nov 19, 2024
Marenz added a commit to frequenz-floss/frequenz-dispatch-python that referenced this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
part:dispatcher part:docs Affects the documentation part:test-utils Affects the test utilities part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) status:blocked Other issues must be resolved before this can be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants