-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new BaseClient version #109
Conversation
Marenz
commented
Nov 18, 2024
•
edited
Loading
edited
- Reset release notes after release
- Update dependency frequenz-client-base to 0.8.0
Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
"frequenz-client-base >= 0.7.0, < 0.8.0", | ||
"frequenz-client-base >= 0.8.0, < 0.9.0", | ||
"frequenz-client-common >= 0.1.0, < 0.3.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't you update RELEASE_NOTES?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm I usually update them if it's something the user can see, but nothing changed from their perspective in this case, just an indirect dependency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, the only issue with bumping dependencies with breaking changes is users are forced to upgrade the dependency too (the thing that is triggering all these release trains), which will force them to update the code because the changes are breaking. This is why we usually document disruptive dependency bumps, because it has a high potential of actually affecting the user at the end. But in development mode (v0.x.x) I think is not that bad if it is missing in the release notes, people are supposed to expect breakage anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question as Ela, otherwise LGTM. Feel free to merge if you add notes or you think notes are not necessary because you plan to invalidate the previous version or something.
Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
- **Update to latest channels & dispatch client** Blocked by: * frequenz-floss/frequenz-sdk-python#1109 * frequenz-floss/frequenz-client-dispatch-python#109 * frequenz-floss/frequenz-client-microgrid-python#100
- **Update to latest channels & dispatch client** Blocked by: * frequenz-floss/frequenz-sdk-python#1109 * frequenz-floss/frequenz-client-dispatch-python#109 * frequenz-floss/frequenz-client-microgrid-python#100