Skip to content

ci: Add contents permission to publish-docs#33

Merged
leandro-lucarella-frequenz merged 1 commit intofrequenz-floss:v0.x.xfrom
llucax:mkdocs-fix
Nov 4, 2022
Merged

ci: Add contents permission to publish-docs#33
leandro-lucarella-frequenz merged 1 commit intofrequenz-floss:v0.x.xfrom
llucax:mkdocs-fix

Conversation

@leandro-lucarella-frequenz
Copy link
Contributor

@leandro-lucarella-frequenz leandro-lucarella-frequenz commented Nov 4, 2022

Without this permissions the job can't publish GitHub Pages.

@llucax
ci: Add contents permission to publish-docs
b645fdc 
Without this permissions the job can't publish GitHub Pages.

Signed-off-by: Leandro Lucarella <leandro.lucarella@frequenz.com>
@leandro-lucarella-frequenz leandro-lucarella-frequenz added part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) type:bug Something isn't working labels Nov 4, 2022
@leandro-lucarella-frequenz leandro-lucarella-frequenz added this to the v0.11.0 milestone Nov 4, 2022
@leandro-lucarella-frequenz leandro-lucarella-frequenz requested a review from a team as a code owner November 4, 2022 09:02
@leandro-lucarella-frequenz
Copy link
Contributor Author

leandro-lucarella-frequenz commented Nov 4, 2022 •
edited
Loading

I also had to add a specific branch protection for the branch gh-pages so it can be pushed without going through a PR. Still force-pushes and deletion are not allowed. At some point it might be good to create a special CI user and only allow pushing to this branch without PRs to this user, but not something to do right now.

@leandro-lucarella-frequenz leandro-lucarella-frequenz merged commit 3d8e919 into frequenz-floss:v0.x.x Nov 4, 2022
@leandro-lucarella-frequenz leandro-lucarella-frequenz deleted the mkdocs-fix branch November 4, 2022 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ela-kotulska-frequenz ela-kotulska-frequenz Awaiting requested review from ela-kotulska-frequenz ela-kotulska-frequenz was automatically assigned from frequenz-floss/python-sdk-team

1 more reviewer

@sahas-subramanian-frequenz sahas-subramanian-frequenz sahas-subramanian-frequenz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@leandro-lucarella-frequenz leandro-lucarella-frequenz

Labels

part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) type:bug Something isn't working

Projects

None yet

Milestone

v0.11.0

Development

Successfully merging this pull request may close these issues.

3 participants

@leandro-lucarella-frequenz @sahas-subramanian-frequenz @llucax