Skip to content

Conversation

@saraswatpuneet
Copy link
Collaborator

@saraswatpuneet saraswatpuneet commented Oct 13, 2025

Goal

The goal of this PR is to update polkadotjs to compatible latest in api-augment to release a patch for npm package. Causing codec error in downstream libraries, for example

Property 'toNumber' does not exist on type 'Codec'.

Tasks Performed

  • Polkadot libs to 16.4.3 -> 16.4.8
  • noble curves update and fixing respective e2e
  • Typescript enforces import interfaces as type interface, probably came from pdot updating typescript
  • fix tests

Discussion

Checklist

  • Updated Pallet Readme?
  • Updated js/api-augment for Custom RPC APIs?
  • Design doc(s) updated?
  • Unit Tests added?
  • e2e Tests added?
  • Benchmarks added?
  • Spec version incremented?

@saraswatpuneet saraswatpuneet changed the title Update polkadotjs version: then release a -1 patch downstream codec fixes Update polkadotjs version to release a updated package causing codec issue 1.17.5 Oct 13, 2025
@saraswatpuneet saraswatpuneet changed the title Update polkadotjs version to release a updated package causing codec issue 1.17.5 Update polkadotjs version to release a updated package causing codec issue with 1.17.5 Oct 13, 2025
@saraswatpuneet saraswatpuneet requested review from a team, JoeCap08055, aramikm, claireclark1, enddynayn, mattheworris and shannonwells and removed request for a team October 13, 2025 16:38
# Checklist
- [ ] Updated Pallet Readme?
- [ ] Updated js/api-augment for Custom RPC APIs?
- [ ] Updated api-augment package.json with any new dependencies (if applicable)?
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will help in keep track of if packages need to be updated, cannot rely on e2e since there package lock is not used

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, I'll add something like that to other PR template checklists

@saraswatpuneet
Copy link
Collaborator Author

Ok atleast it is reproducible in ci now,

Copy link
Collaborator

@JoeCap08055 JoeCap08055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One non-blocking comment.
Much-needed version dep bump 🙏🏻

@saraswatpuneet saraswatpuneet changed the title Update polkadotjs version to release a updated package causing codec issue with 1.17.5 Update polkadotjs version to release 1.6.8 across all npm dependencies and also update all potential libaries to latest Oct 14, 2025
@saraswatpuneet saraswatpuneet changed the title Update polkadotjs version to release 1.6.8 across all npm dependencies and also update all potential libaries to latest Update polkadotjs version to release 1.16.8 across all npm dependencies and also update all potential libaries to latest Oct 14, 2025
@saraswatpuneet saraswatpuneet changed the title Update polkadotjs version to release 1.16.8 across all npm dependencies and also update all potential libaries to latest Update polkadotjs version to release 16.4.8 across all npm dependencies and also update all potential libaries to latest Oct 14, 2025
@saraswatpuneet saraswatpuneet enabled auto-merge (squash) October 14, 2025 22:01
Copy link
Collaborator

@shannonwells shannonwells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the package.json files and also looked at the latest docs for @noble/curves and hashes

@saraswatpuneet saraswatpuneet merged commit 775622f into main Oct 15, 2025
99 of 100 checks passed
@saraswatpuneet saraswatpuneet deleted the update_polkadotjs_version branch October 15, 2025 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants