-
Notifications
You must be signed in to change notification settings - Fork 24
Update polkadotjs version to release 16.4.8 across all npm dependencies and also update all potential libaries to latest #2624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…braries that have upgraded
-1 patch downstream codec fixes1.17.5
1.17.51.17.5
| # Checklist | ||
| - [ ] Updated Pallet Readme? | ||
| - [ ] Updated js/api-augment for Custom RPC APIs? | ||
| - [ ] Updated api-augment package.json with any new dependencies (if applicable)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will help in keep track of if packages need to be updated, cannot rely on e2e since there package lock is not used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, I'll add something like that to other PR template checklists
|
Ok atleast it is reproducible in ci now, |
JoeCap08055
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One non-blocking comment.
Much-needed version dep bump 🙏🏻
1.17.5
shannonwells
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed the package.json files and also looked at the latest docs for @noble/curves and hashes
Goal
The goal of this PR is to update polkadotjs to compatible latest in api-augment to release a patch for npm package. Causing codec error in downstream libraries, for example
Property 'toNumber' does not exist on type 'Codec'.Tasks Performed
16.4.3 -> 16.4.8type interface, probably came from pdot updating typescriptDiscussion
Checklist