update mocks to have >1 ED and update breaking tests #2619
Conversation
claireclark1
requested review from
aramikm,
enddynayn,
mattheworris and
shannonwells
and removed request for
wilwade
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
…odify-mockrs-to-have-ed-1-to-test-balances-less-than-ed
saraswatpuneet
left a comment
saraswatpuneet
left a comment
There was a problem hiding this comment.
lgtm, since benchmarking.rs got updated we may want to run benchmarks for time-release
There was a problem hiding this comment.
I'm not really understanding why these benchmarks wouldn't have worked without the ED.
Or is it just that we don't want the generated weights to include reaping or creating an account?
There was a problem hiding this comment.
I thought it was due to changes in the mock runtime, however, benchmarking uses the real runtime. Therefore, I am guessing it might be due to changes in the polkadot-sdk?
I double checked by removing the benchmarking.rs changes: removing the ED causes the benchmarking tests to fail because the values in the time-release schedule are less than ED, and the error is: "Account cannot exist with the funds that would be given".
JoeCap08055
left a comment
JoeCap08055
left a comment
There was a problem hiding this comment.
One non-blocking question, but otherwise looks good.
Nice work!
claireclark1
deleted the
1852-pallet-unit-tests-concerning-balances-modify-mockrs-to-have-ed-1-to-test-balances-less-than-ed
branch
Goal
The goal of this PR is to update mocks to have >1 ED so that we can test over and under cases in the future.
Closes #1852
Discussion
Checklist