[Chore] remove deprecation from create_provider
#2613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saraswatpuneet
changed the title
create_provider create_provider
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
saraswatpuneet
requested review from
a team,
JoeCap08055,
aramikm,
claireclark1,
enddynayn,
mattheworris and
shannonwells
and removed request for
a team
JoeCap08055
approved these changes
Sep 22, 2025
aramikm
approved these changes
Sep 22, 2025
Collaborator
aramikm
left a comment
aramikm
left a comment
There was a problem hiding this comment.
Might need a spec version bump
Collaborator
Author
|
@aramikm this change does not change the metadata, the CI passed without spec version update |
mattheworris
approved these changes
Sep 22, 2025
Collaborator
@saraswatpuneet Correct. But, FYI, the upcoming Metadata V16 will include deprecation info. We're still on V15. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this PR is to retain and remove
deprecatedmarking fromcreate_providersince it is actively used in paseo/local testing. Also notify repository of changes expected to be implemented.Closes #2610
Discussion
Checklist