bugfix: fixed capacity estimation RPC #2612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aramikm
requested review from
JoeCap08055,
enddynayn,
mattheworris,
saraswatpuneet and
shannonwells
and removed request for
wilwade
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
saraswatpuneet
approved these changes
Sep 19, 2025
github-actions
bot
added
the
metadata-changed
JoeCap08055
reviewed
Sep 19, 2025
Collaborator
JoeCap08055
left a comment
JoeCap08055
left a comment
There was a problem hiding this comment.
Good catch. Do we want to add/update any tests? I believe we have e2e tests that deal with stable weights...
Collaborator
Author
|
@JoeCap08055 This is only on the RPC side and doesn't involve the stable weights directly. I don't think we had any tests that needed fixing but I can maybe add one just in case. |
github-actions
bot
removed
the
metadata-changed
github-actions
bot
added
the
metadata-changed
mattheworris
approved these changes
Sep 19, 2025
Collaborator
mattheworris
left a comment
mattheworris
left a comment
There was a problem hiding this comment.
- Read through changes
🚢 it!
enddynayn
reviewed
Sep 19, 2025
| const tx = ExtrinsicHelper.api.tx.frequencyTxPayment.payWithCapacity(insideTx); | ||
| const signedTx = await firstValueFrom(tx.signAsync(capacityProviderKeys)); | ||
| const signedHex = signedTx.toHex(); | ||
| // it's important to submit a signed extrinsic to the rpc to get an accurate estimate due to the actual length of extrinsic and etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this PR is to fix the bug in capacity estimation RPC.
Closes #2579
Discussion
Checklist
Verification
As shown Calculated and deducted capacity values are really close.
2,741,950 in RPC2,737,627 in Event