Skip to content

Conversation

@saraswatpuneet
Copy link
Collaborator

@saraswatpuneet saraswatpuneet commented Aug 25, 2025

Goal

The goal of this PR is to introduce a general purpose RPC to fetch provider context. In this rpc if user dont specify application id or locale, a default profile is returned which is registered at time of provider creation otherwise return details for application id provided

Closes #2526

Discussion

Checklist

  • Updated Pallet Readme?
  • Updated js/api-augment for Custom RPC APIs?
  • Design doc(s) updated?
  • Unit Tests added?
  • e2e Tests added?
  • Benchmarks added?
  • Spec version incremented?

@saraswatpuneet saraswatpuneet changed the base branch from main to feat/provider-context-development August 25, 2025 16:05
@codecov
Copy link

codecov bot commented Aug 25, 2025

Codecov Report

❌ Patch coverage is 69.23077% with 12 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pallets/msa/src/lib.rs 71.05% 11 Missing ⚠️
common/primitives/src/msa.rs 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
pallets/msa/src/types.rs 93.25% <ø> (ø)
common/primitives/src/msa.rs 87.50% <0.00%> (-0.93%) ⬇️
pallets/msa/src/lib.rs 91.16% <71.05%> (-0.59%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot added the metadata-changed Metadata has changed since the latest full release label Aug 25, 2025
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Aug 25, 2025
@saraswatpuneet saraswatpuneet changed the title 2526 RPC for provider context fetching provider/application context give inputs 2526 RPC for provider context fetching provider/application context Aug 26, 2025
@github-actions github-actions bot added the metadata-changed Metadata has changed since the latest full release label Aug 26, 2025
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Aug 26, 2025
Copy link
Collaborator

@aramikm aramikm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good but I think we should not add new RPC if not absolutely justified.

@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Aug 26, 2025
@github-actions github-actions bot removed the metadata-changed Metadata has changed since the latest full release label Aug 26, 2025
@saraswatpuneet saraswatpuneet changed the title 2526 RPC for provider context fetching provider/application context 2526 RuntimeApi for provider context fetching provider/application context Aug 26, 2025
@github-actions github-actions bot added the metadata-changed Metadata has changed since the latest full release label Aug 26, 2025
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Aug 27, 2025
@github-actions github-actions bot removed the metadata-changed Metadata has changed since the latest full release label Aug 27, 2025
@github-actions github-actions bot added the metadata-changed Metadata has changed since the latest full release label Aug 27, 2025
@saraswatpuneet saraswatpuneet merged commit 93fc1f0 into feat/provider-context-development Aug 27, 2025
32 checks passed
@saraswatpuneet saraswatpuneet deleted the 2526_rpcs branch August 27, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

metadata-changed Metadata has changed since the latest full release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants