-
Notifications
You must be signed in to change notification settings - Fork 24
Upgrade polkadot to latest stable-2506-2: Optimizations to FATx pool addressed #2559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
JoeCap08055
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're moving Rust versions, do we also need or want to update the nightly toolchain that we use for formatting and linting? It's specified in a couple places in the CI workflows, as well as the main Makefile.
| fn alias_origin() -> Result<(xcm::benchmarks::Location, xcm::benchmarks::Location), BenchmarkError> { | ||
| Err(BenchmarkError::Skip) | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: is this related to the sdk upgrade? Seems like an xcm related change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattheworris yes these are newly added methods and following the change it seems this does not applies to us, @enddynayn there are come changes here that relates to xcm
mattheworris
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Read through changes, non-blocking comment.
🚢 it!
aramikm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. We need to make sure to upgrade all the nodes first and then we can do runtime upgrades due to using a new hostfunction inside the runtime.
| type WeightInfo = (); | ||
| type ConsensusHook = ConsensusHook; | ||
| type SelectCore = DefaultCoreSelector<Runtime>; | ||
| type RelayParentOffset = ConstU32<0>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@enddynayn If you don't have any opinions I think we can keep this as 0. Feel free to close the comment
Goal
The goal of this PR is to upgrade polkadot version to 2506-1
Following changes took place
RuntimeEventinConfigis being made redundant ( haven't removed it but added allow deprecated for now)runtume_interfacethat rust was warning about but it's polkadot design choice.Polkadot Notes on migration to 2506
Closes #2521
Discussion
fatxpool: limits handling optimizations and fixes paritytech/polkadot-sdk#8596Checklist