Skip to content

Conversation

@saraswatpuneet
Copy link
Collaborator

@saraswatpuneet saraswatpuneet commented Aug 14, 2025

Goal

The goal of this PR is to upgrade polkadot version to 2506-1

Following changes took place

  • Host functions require some safe marshalling.
  • xcm and assets weights updated to match latest interface.
  • RuntimeEvent in Config is being made redundant ( haven't removed it but added allow deprecated for now)
  • Updated tomls
  • Suppressed a warning around runtume_interface that rust was warning about but it's polkadot design choice.
  • Update node layer with updated functions and introduce new arguments
  • update xcm configs in runtime with latest trait
  • address clippy errors

Polkadot Notes on migration to 2506
Closes #2521

Discussion

Checklist

  • Updated Pallet Readme?
  • Updated js/api-augment for Custom RPC APIs?
  • Design doc(s) updated?
  • Unit Tests added?
  • e2e Tests added?
  • Benchmarks added?
  • Spec version incremented?

@saraswatpuneet saraswatpuneet marked this pull request as ready for review August 14, 2025 21:37
@codecov
Copy link

codecov bot commented Aug 14, 2025

Codecov Report

❌ Patch coverage is 55.00000% with 9 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
common/primitives/src/offchain.rs 40.00% 6 Missing ⚠️
pallets/msa/src/offchain_storage.rs 66.66% 3 Missing ⚠️
Files with missing lines Coverage Δ
pallets/capacity/src/lib.rs 88.59% <ø> (ø)
pallets/handles/src/lib.rs 94.61% <ø> (ø)
pallets/messages/src/lib.rs 93.80% <ø> (ø)
pallets/msa/src/lib.rs 92.56% <100.00%> (ø)
pallets/time-release/src/lib.rs 93.29% <ø> (ø)
pallets/msa/src/offchain_storage.rs 78.19% <66.66%> (-0.61%) ⬇️
common/primitives/src/offchain.rs 88.75% <40.00%> (-9.85%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Aug 14, 2025
@github-actions github-actions bot added the metadata-changed Metadata has changed since the latest full release label Aug 14, 2025
Copy link
Collaborator

@JoeCap08055 JoeCap08055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're moving Rust versions, do we also need or want to update the nightly toolchain that we use for formatting and linting? It's specified in a couple places in the CI workflows, as well as the main Makefile.

@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Aug 15, 2025
@saraswatpuneet saraswatpuneet requested review from a team, enddynayn, mattheworris and shannonwells and removed request for a team August 15, 2025 15:13
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Sep 24, 2025
@saraswatpuneet saraswatpuneet marked this pull request as ready for review September 24, 2025 16:17
@github-actions github-actions bot removed the metadata-changed Metadata has changed since the latest full release label Sep 24, 2025
fn alias_origin() -> Result<(xcm::benchmarks::Location, xcm::benchmarks::Location), BenchmarkError> {
Err(BenchmarkError::Skip)
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: is this related to the sdk upgrade? Seems like an xcm related change.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattheworris yes these are newly added methods and following the change it seems this does not applies to us, @enddynayn there are come changes here that relates to xcm

Copy link
Collaborator

@mattheworris mattheworris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Read through changes, non-blocking comment.
    🚢 it!

@github-actions github-actions bot added the metadata-changed Metadata has changed since the latest full release label Sep 24, 2025
Copy link
Collaborator

@aramikm aramikm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. We need to make sure to upgrade all the nodes first and then we can do runtime upgrades due to using a new hostfunction inside the runtime.

type WeightInfo = ();
type ConsensusHook = ConsensusHook;
type SelectCore = DefaultCoreSelector<Runtime>;
type RelayParentOffset = ConstU32<0>;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@enddynayn If you don't have any opinions I think we can keep this as 0. Feel free to close the comment

@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Sep 25, 2025
@github-actions github-actions bot removed the metadata-changed Metadata has changed since the latest full release label Sep 25, 2025
@github-actions github-actions bot added the metadata-changed Metadata has changed since the latest full release label Sep 25, 2025
@github-actions github-actions bot removed the metadata-changed Metadata has changed since the latest full release label Sep 25, 2025
@github-actions github-actions bot added the metadata-changed Metadata has changed since the latest full release label Sep 25, 2025
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Sep 29, 2025
@saraswatpuneet saraswatpuneet merged commit 0470462 into main Sep 29, 2025
35 checks passed
@saraswatpuneet saraswatpuneet deleted the 2521_update_polkadot_version branch September 29, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change/major Major Changes in this PR metadata-changed Metadata has changed since the latest full release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade to Polkadot Release polkadot-stable2506

6 participants